Description

This PR addresses GAZEBO-1802, a TypeError: b.forEach is not a function occurring in src/ui/FileViewer/ToggleHeader/Title/Title.tsx.

Code Example

Notable Changes

Root Cause:
The useLocationParams hook, which utilizes qs.parse, returns a plain string for single-value query parameters (e.g., ?flags=some-flag-name) instead of an array. This string then overwrites the default empty array for params.flags. When params?.flags?.forEach() is subsequently called, it attempts to invoke forEach on a string, leading to the TypeError.

Solution:

1. Type Update: Modified the LocationParams type to correctly reflect that params.flags can be either a string or string[] as returned by qs.parse.
2. Parameter Normalization: Introduced a flagsParam variable within the TitleFlags component. This variable uses Array.isArray() to ensure that params.flags is always coerced into an array, regardless of whether qs.parse returned a string or an array.
3. Safe Usage: Updated the useState initialization for selectedFlags and the .forEach() call to use the newly normalized flagsParam. This guarantees that .forEach() is always called on an array, preventing the TypeError.

This fix is localized to the TitleFlags component, ensuring that the forEach operation is always performed on a valid array without introducing global changes to useLocationParams.

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes GAZEBO-1802